Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CITATION.cff and fix F401 warning #183

Merged
merged 9 commits into from
Jul 30, 2024
Merged

CITATION.cff and fix F401 warning #183

merged 9 commits into from
Jul 30, 2024

Conversation

kashif
Copy link
Contributor

@kashif kashif commented Jul 30, 2024

No description provided.

@kashif kashif requested a review from alvarobartt July 30, 2024 08:18
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@kashif kashif changed the title fix F401 warning CITATION.cff and fix F401 warning Jul 30, 2024
Copy link
Member

@alvarobartt alvarobartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Also w.r.t. the style changes are those introduced by black? If so, maybe at some point we could include a pre-commit to ensure that the styling changes match the expected ones.

src/alignment/__init__.py Show resolved Hide resolved
@kashif kashif merged commit 9856335 into huggingface:main Jul 30, 2024
2 of 3 checks passed
@kashif kashif deleted the all branch July 30, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants