Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test for converting tensor to proper dtype #983

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Fix test for converting tensor to proper dtype #983

merged 2 commits into from
Jan 18, 2023

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Jan 18, 2023

I made a typo in #920 and forgot a not while copy-pasting some code 😬
This PR fixes that.

@sgugger sgugger requested a review from muellerzr January 18, 2023 15:34
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 18, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

muellerzr
muellerzr approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oopsie! Is it possible we could have written a test to catch this? Or not as much and it's just a silent-never-called bug

@sgugger sgugger merged commit 7e41361 into main Jan 18, 2023
@sgugger sgugger deleted the fix_set_tensor_to_device branch January 18, 2023 16:21
@sgugger sgugger mentioned this pull request Jan 18, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muellerzr muellerzr muellerzr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sgugger @HuggingFaceDocBuilderDev @muellerzr