Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better description for improper kwargs #894

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Better description for improper kwargs #894

merged 2 commits into from
Nov 29, 2022

Conversation

muellerzr
Copy link
Collaborator

Ties into #870, writes a more descriptive assert flag that states it must inherit KwargHandler

@muellerzr muellerzr added the enhancement New feature or request label Nov 29, 2022
@muellerzr muellerzr requested a review from sgugger November 29, 2022 16:52
@muellerzr muellerzr changed the title Better flag for kwargs Better description for improper kwargs Nov 29, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 29, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@muellerzr muellerzr merged commit f4eee1c into main Nov 29, 2022
@muellerzr muellerzr deleted the better-warn branch November 29, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muellerzr @HuggingFaceDocBuilderDev @sgugger