-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DeepSpeed support #82
Conversation
354a60e
to
547ec93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your work on this! This is great! I left a couple of comments to polish the implementation.
7189100
to
63555d4
Compare
Note for before merging this: the PR should be rebased on master and the reference to the model added in the |
63555d4
to
acde238
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for all your amazing work! I think we are in good shape to have this merge, I just left some last comments around naming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, great job implementing that @vasudevgupta7!
Two items that should be handled in my opinion:
- It seems that
accelerate
will not run once this PR is merged ifdeepspeed
isn't in the environment. Is this correct? - There really should be some tests to ensure that everything is working correctly. I would advocate for a test suite that runs accelerate with and without deepspeed, but I know the infra to support that isn't there yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few last tweaks to the doc and this should be good to merge!
Co-authored-by: Sylvain Gugger <[email protected]>
This PR will add DeepSpeed support to Accelerate.
User's code should look like this:
Running the script
@sgugger