Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for GPU-ID specification on CLI #732

Merged
merged 9 commits into from
Sep 30, 2022
Merged

Allow for GPU-ID specification on CLI #732

merged 9 commits into from
Sep 30, 2022

Conversation

muellerzr
Copy link
Collaborator

Closes #543 by adding a --gpu_ids param to both the CLI as well as config, and has the CLI launcher utilize it as a result. This essentially just sets CUDA_VISIBLE_DEVICES dynamically before launching code

If need for it to occur in notebook_launcher is desired, I'll expand this further

@muellerzr muellerzr added the enhancement New feature or request label Sep 30, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 30, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@muellerzr muellerzr marked this pull request as draft September 30, 2022 15:37
sgugger
sgugger approved these changes Sep 30, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Thanks for adding this!

@muellerzr muellerzr marked this pull request as ready for review September 30, 2022 15:48
@sgugger sgugger mentioned this pull request Sep 30, 2022
Closed
pacman100
pacman100 reviewed Sep 30, 2022
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, nice addition. However, I don't think CUDA_VISIBLE_DEVICES would do anything for Apple Silicon GPUs.

@muellerzr
Copy link
Collaborator Author

muellerzr commented Sep 30, 2022 •
edited
Loading

@pacman100 correct, this is solely for non-M1 GPUs, I'll specify that in the info description for it

@muellerzr muellerzr merged commit 870a7ba into main Sep 30, 2022
@muellerzr muellerzr deleted the gpu-ids branch September 30, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacman100 pacman100 pacman100 left review comments

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: Specifying GPU IDs
4 participants
@muellerzr @HuggingFaceDocBuilderDev @pacman100 @sgugger