Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default for num processes #726

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Fix default for num processes #726

merged 2 commits into from
Sep 27, 2022

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Sep 27, 2022

As pointed out in #717, the current default for num_processes erases the value set by the config, which we don't want. This PR fixes that.

@sgugger sgugger requested a review from muellerzr September 27, 2022 20:46
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 27, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

muellerzr
muellerzr approved these changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Great solution :)

Left a single suggestion (since it was over the changed files, had to be split). Basically I think we should set first then update the warning with how many values it was set to

@sgugger sgugger merged commit d21c213 into main Sep 27, 2022
@sgugger sgugger deleted the fix_default_num_processes branch September 27, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muellerzr muellerzr muellerzr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sgugger @HuggingFaceDocBuilderDev @muellerzr