Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docstrings and add examples where it makes sense #666

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

muellerzr
Copy link
Collaborator

This PR fixes a few nits in the docstrings (such as the Attributes issue discussed awhile ago in more places), as well as adds a few examples to places where users could get confused on the usage, or it is not extremely straightforward to use from the documentation.

These specific cases are ones where numerous issues have been opened, asking how to use the specific item.

This helps us document it in two places: the official documentation/tutorials for folks who need more information, and the docstring for folks who do not and just need the boilerplate.

@muellerzr muellerzr added the documentation Improvements or additions to documentation label Aug 29, 2022
@muellerzr muellerzr requested a review from sgugger August 29, 2022 19:50
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 29, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot for adding all of this!

@muellerzr muellerzr merged commit 5e51488 into main Sep 1, 2022
@muellerzr muellerzr deleted the docstring-examples branch September 1, 2022 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants