Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduler in gradient accumulation example #500

Merged
merged 4 commits into from
Jul 8, 2022
Merged

Conversation

muellerzr
Copy link
Collaborator

Doesn't divide the number of steps in the scheduler since Accelerate handles it

@muellerzr muellerzr added the bug Something isn't working label Jul 8, 2022
@muellerzr muellerzr requested a review from sgugger July 8, 2022 16:48
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 8, 2022

The documentation is not available anymore as the PR was closed or merged.

@muellerzr muellerzr requested a review from sgugger July 8, 2022 17:14
src/accelerate/scheduler.py Outdated Show resolved Hide resolved
@muellerzr muellerzr merged commit b20f90a into main Jul 8, 2022
@muellerzr muellerzr deleted the fix-example branch July 8, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants