Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subtle bug in BF16 #463

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Fix subtle bug in BF16 #463

merged 2 commits into from
Jun 23, 2022

Conversation

muellerzr
Copy link
Collaborator

This PR fixes two subtle bugs I noticed post my previous PR:

  • We currently can no longer get the mixed precision from the environment variable (oops)
  • If on a TPU and you select bf16 an error will be raised in the bf16 flag, this has the flag get ignored if a tpu is available in the check as all of the bf16 logic for TPU's lives in state

@muellerzr muellerzr added bug Something isn't working TPU Bug or feature on TPU platforms labels Jun 23, 2022
@muellerzr muellerzr requested a review from sgugger June 23, 2022 11:57
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 23, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Jun 23, 2022
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@muellerzr muellerzr merged commit 3ccbd9f into main Jun 23, 2022
@muellerzr muellerzr deleted the bf16-fix branch June 23, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
bug Something isn't working TPU Bug or feature on TPU platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muellerzr @HuggingFaceDocBuilderDev @sgugger