Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to evaluate for metrics #417

Merged
merged 11 commits into from
Jun 1, 2022
Merged

Switch to evaluate for metrics #417

merged 11 commits into from
Jun 1, 2022

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented May 31, 2022

This PR switches all example scripts to use evaluate instead of datasets for the metric computation. cc @lvwerra

@sgugger sgugger requested a review from muellerzr May 31, 2022 20:31
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 31, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Comment on lines +15 to +17
run: |
pip install --upgrade pip
pip install -e .[test,test_trackers]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some micro optimization that can be done I found that can save us a number of minutes on each CI, and will actually let this no longer need to be a thing. I'll make a PR after this with that, it'll simplify some things quite a bit :)

@sgugger sgugger merged commit d04e8e2 into main Jun 1, 2022
@sgugger sgugger deleted the use_evaluate branch June 1, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants