Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Accelerate CLI CPU option + small fix for W&B tests #311

Merged
merged 3 commits into from
Apr 8, 2022
Merged

Conversation

muellerzr
Copy link
Collaborator

@muellerzr muellerzr commented Apr 8, 2022

Fix Accelerate CLI CPU option + Small W&B testfix

What does this add?

  • Change CPU param to use convert_yes_no_to_bool in the CLI Config
  • Changes the logic for W&B .log tests to be assertTrue and "str" in output

Why is this needed?

  • Fixes an undocumented issue where the Accelerate Config CPU param expected a boolean argument, but it was phrased in a way where it seemed like yes/no could be passed in forums post
  • Noticed that the CI seemed to be slightly unstable with the W&B log parsing (unsurprising), so rather than a self.assertEqual I opted for a self.assertTrue and runs an in check, since we only care that the value itself is in the log, with potentially a little bit of noise

@muellerzr muellerzr requested a review from sgugger April 8, 2022 15:42
@muellerzr muellerzr changed the title bug Fix Accelerate CLI CPU option Apr 8, 2022
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 8, 2022

The documentation is not available anymore as the PR was closed or merged.

@muellerzr muellerzr changed the title Fix Accelerate CLI CPU option Fix Accelerate CLI CPU option + small fix for W&B tests Apr 8, 2022
@muellerzr muellerzr merged commit fa2ec4b into main Apr 8, 2022
@muellerzr muellerzr deleted the env-bugs branch April 8, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants