Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip tied weights disk offload test #2782

Merged
merged 4 commits into from
May 16, 2024
Merged

Skip tied weights disk offload test #2782

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4cc6eed
skip
SunMarc May 15, 2024
0762fa9
fix
SunMarc May 15, 2024
6864199
quality
SunMarc May 15, 2024
c55e843
fix comment
SunMarc May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/test_big_modeling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,12 @@ def forward(self, x):
del model
gc.collect()

# This test fails because sometimes data_ptr() of compute2.weight is the same as compute1.weight.
# I checked that the values are not the same but it gives the same address. This does not happen on my local machine.
@require_cuda
@unittest.skip(
"Flaky test, we should have enough coverage with test_dispatch_model_tied_weights_memory_with_nested_offload_cpu test"
)
def test_dispatch_model_tied_weights_memory_with_nested_offload_disk(self):
# Test that we do not duplicate tied weights at any point during dispatch_model call.

Expand Down
Loading