Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Automatic checkpoint path inference issue #1989

Merged

Conversation

BenjaminBossan
Copy link
Member

What does this PR do?

Resolves #1983

Note: I basically duplicated an existing test 99% to check for this bug. My reasoning was that duplication is better for this test than abstracting it. LMK if you prefer to abstract it instead.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Resolves huggingface#1983

Note: I basically duplicated an existing test 99% to check for this bug.
My reasoning was that duplication is better for this test than
abstracting it. LMK if you prefer to abstract it instead.
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 19, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! I think that we can leave it as it is. If needeed, we can do the abstraction in another PR as there is also another test that is very similar test_can_resume_training_with_folder

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There's some good stuff in here I'd want to extract out into the test utils certainly (esp your context manager) but overall lg2m :)

@BenjaminBossan BenjaminBossan merged commit 80da9cf into huggingface:main Sep 19, 2023
@BenjaminBossan BenjaminBossan deleted the fix-issue-1983-checkpoint-path branch September 19, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileNotFoundError from load_state caused the input_dir is joined twice
4 participants