Avoid double wrapping of all accelerate.prepare objects #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
pushed a commit
that referenced
this pull request
Jun 7, 2023
* Add step reset to free memory * Check if not Accelerated Optimizer * Continue * Another try * Check the rest * Try with just check on init * Change logic based on review * Update * Oops very big logic issue!
|
@muellerzr @sgugger Hi! I have zero familiarity with the code base, but is it intentional that the added |
|
Nope, it is not! Would you like to put in a fix @Yura52? Otherwise I can do so quickly :) |
Here is the PR: #1560 @muellerzr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves double nested wrapping issues linked as a side-effect to huggingface/transformers#24050.
Also resets step to 0 during free_memory