Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid double wrapping of all accelerate.prepare objects #1554

Closed
wants to merge 8 commits into from
Closed

Avoid double wrapping of all accelerate.prepare objects #1554

wants to merge 8 commits into from

Conversation

muellerzr
Copy link
Collaborator

Solves double nested wrapping issues linked as a side-effect to huggingface/transformers#24050.

Also resets step to 0 during free_memory

@muellerzr muellerzr requested a review from sgugger June 7, 2023 17:11
pacman100
pacman100 approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 7, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@muellerzr muellerzr closed this Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacman100 pacman100 pacman100 approved these changes

@sgugger sgugger Awaiting requested review from sgugger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muellerzr @HuggingFaceDocBuilderDev @pacman100