Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix skip first batch being perminant #1466

Merged
merged 3 commits into from
May 22, 2023
Merged

Fix skip first batch being perminant #1466

merged 3 commits into from
May 22, 2023

Conversation

muellerzr
Copy link
Collaborator

Solves #1451 and adds tests

@muellerzr muellerzr added the bug Something isn't working label May 22, 2023
@muellerzr muellerzr requested a review from sgugger May 22, 2023 15:39
sgugger
sgugger reviewed May 22, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No the dataloader created by skip_batches should not change. In the examples we should use different dataloaders in the first epoch vs subsequent epochs.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 22, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@muellerzr muellerzr requested a review from sgugger May 22, 2023 16:27
sgugger
sgugger approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! We will need the same update in the no_trainer examples no the Transformers repo.

@muellerzr muellerzr merged commit 7092089 into main May 22, 2023
@muellerzr muellerzr deleted the skip-first-batch branch May 22, 2023 18:18
@muellerzr muellerzr mentioned this pull request May 23, 2023
Closed
4 tasks
@dumpmemory dumpmemory mentioned this pull request Aug 30, 2023
Closed
4 tasks
@SumanthRH SumanthRH mentioned this pull request Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muellerzr @HuggingFaceDocBuilderDev @sgugger