Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipex intel extension for pytorch integration #1255

Merged
merged 3 commits into from
Mar 30, 2023
Merged

ipex intel extension for pytorch integration #1255

merged 3 commits into from
Mar 30, 2023

Conversation

sywangyi
Copy link
Contributor

@sywangyi sywangyi commented Mar 27, 2023 •
edited
Loading

What does this PR do?
Implements feature request #700

@sywangyi
ipex intel extension for pytorch integration
98c6139 
Co-authored-by: Sourab Mangrulkar <[email protected]>

Co-authored-by: jianan-gu <[email protected]>

Co-authored-by: Wang, Yi A <[email protected]>
@sywangyi
Copy link
Contributor Author

@sgugger @pacman100 @yao-matrix @jianan-gu please review

@sywangyi sywangyi mentioned this pull request Mar 27, 2023
Closed
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 27, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@sywangyi
fix test error
e656c15 
Signed-off-by: Wang, Yi A <[email protected]>
sgugger
sgugger reviewed Mar 27, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a fresh PR. I have some comments, and we would also need to add tests for this.

src/accelerate/accelerator.py Outdated Show resolved Hide resolved
src/accelerate/accelerator.py Outdated Show resolved Hide resolved
src/accelerate/accelerator.py Outdated Show resolved Hide resolved
src/accelerate/utils/dataclasses.py Outdated Show resolved Hide resolved
@sywangyi
Copy link
Contributor Author

Thanks for opening a fresh PR. I have some comments, and we would also need to add tests for this.

I add testcase, please help review, later, I will add doc about this

sgugger
sgugger approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this! @pacman100 could you have a second look?

@sywangyi
Copy link
Contributor Author

@pacman100 could you help with the review?

pacman100
pacman100 reviewed Mar 30, 2023
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, Thank you @sywangyi for adding ipex support and iterating on the previous PR 🤗. I believe adding docs with the below details would help users to get a better idea about when and how to use it:

  1. Brief intro on what ipex does and what is integrated currently in accelerate (only training for now)
  2. How to use the current integration
  3. Link to blog/original docs showing benefits when using ipex on CPU in comparison to without it

For reference, please find the DeepSpeed integration docs here: https://huggingface.co/docs/accelerate/usage_guides/deepspeed

@sywangyi
Copy link
Contributor Author

agree, I will create a new PR for the document. For this PR, could you help with the merge?

@sgugger sgugger merged commit 166520f into huggingface:main Mar 30, 2023
@sywangyi sywangyi deleted the ipex branch March 31, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacman100 pacman100 pacman100 approved these changes

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sywangyi @HuggingFaceDocBuilderDev @pacman100 @sgugger