Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix env var for MPS device on notebook_launcher #1024

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Fix env var for MPS device on notebook_launcher #1024

merged 1 commit into from
Jan 30, 2023

Conversation

muellerzr
Copy link
Collaborator

When adding the ACCELERATE prefix in #890, the notebook_launcher needs to check ACCELERATE_USE_MPS_DEVICE

Closes #1022

@muellerzr muellerzr added the bug Something isn't working label Jan 30, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 30, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

pacman100
pacman100 approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this! 🤗

@muellerzr muellerzr merged commit fe709a2 into main Jan 30, 2023
@muellerzr muellerzr deleted the mps-env branch January 30, 2023 14:33
@muellerzr muellerzr mentioned this pull request Jan 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacman100 pacman100 pacman100 approved these changes

@sgugger sgugger sgugger approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to use MPS device
4 participants
@muellerzr @HuggingFaceDocBuilderDev @pacman100 @sgugger