Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve print speed indicators (issue #71) #83

Merged
merged 1 commit into from
Feb 16, 2020

Conversation

DrLex0
Copy link
Contributor

@DrLex0 DrLex0 commented Feb 16, 2020

Get rid of the repeating colors and use a gradient instead.
Also sort the speed listings.
Also fix missing initialization of mm^3/sec arrays that caused bogus
values to be displayed.
I bet multiple people have already done something similar in their
forks, but I'd like to see this on http://gcode.ws/.

Before:
PR-before

After:
PR-after

Get rid of the repeating colors and use a gradient instead.
Also sort the speed listings.
Also fix missing initialization of mm^3/sec arrays that caused bogus
values to be displayed.
I bet multiple people have already done something similar in their
forks, but I'd like to see this on http://gcode.ws/.
@hudbrog hudbrog merged commit 3148993 into hudbrog:master Feb 16, 2020
@hudbrog
Copy link
Owner

hudbrog commented Feb 16, 2020

Personally, random colors were better for me at the time of development, because they allowed to easily see when slicer decided to go something weird (i.e. for some reason volumetric speed have changed, like on your 'before' picture - one 'magenta' line in otherwise black infill, there is no reason for the flow to be different there). But you are not the first one who thinks that gradient colors are more useful there, so be it. Thanks for PR.

@DrLex0
Copy link
Contributor Author

DrLex0 commented Feb 16, 2020

I had thought of making it configurable, but that would have made it more complicated. If someone feels like adding this toggle, it shouldn't be too hard though.
Thanks for merging!

@DrLex0 DrLex0 deleted the better-speed-display branch February 16, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants