-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Coffeescript #1694
Remove Coffeescript #1694
Conversation
… longer load BREAKING CHANGES: Removed es2015.js file; import index.js file instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well Done! Keep up good work!
🎉 This PR is included in version 10.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Why remove this and break lots of plugins in the ecosystem? I don't see this tied to an issue with discussion or anything like that. |
A few thoughts: Version 10.0.5 still supports coffeescript. For those still using hubot and coffeescripts, they should set the hubot peer dependency to version 10. I haven’t seen any GitHub issues about breaking plugins. I’d love to know how many people are still using hubot. And hubot with coffeescripts. Removing coffeescript was on the roadmap issue #1658 Some background: in my research, I found that almost every repo I found was last updated many years ago. Leaving me with the impression that the hubot ecosystem has gone stale. Being the 1 person maintaining it, I’ve been trying to reduce the maintenance surface area. Specifically reducing dependencies. I still get dependabot notifications for the yo generator repo. Gotta figure out what to do with that. I think there’s better adoption for ES6, which is my motivation to modernize hubot and evolve it to a new vision having been left stale for so long. With all those points in mind, I removed coffeescript in v11 as I try to incorporate some of the goals initially defined in the evolution repo and figure out where hubot now fits in todays universe. Are you still using hubot? With coffeescripts? I’d love to hear your story. |
BREAKING CHANGES: Removed CoffeeScript support; .coffee files will no longer load
BREAKING CHANGES: Removed es2015.js file; import index.js file instead