feat: v9 - async/await #1664
Merged
feat: v9 - async/await #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce the Response object has it in it's match property
…hubot into return-results-from-adapter-api
|
🎉 This PR is included in version 8.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1658
BREAKING CHANGE: Robot, Adapter and Response APIs have been replaced with async/await versions. The
asyncmodule was removed.The
asyncmodule was used to execute listeners and middleware, which enabled them to execute after the current call stack finished executing. This is no longer the behavior. Now, listeners and middleware execute in order of registration and as part of the currently executing call stack. In other words, Hubot no longer implements the concept of "unwinding the stack". Listeners and middleware are executed withasync/awaitinstead. They are no longer executed withprocess.nextTick.