Brain: avoid retaining dangerous robot/brain references #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistydemeo
force-pushed
the
fix_circular_reference
branch
from
58c70c0 to
d7411f8
Compare
technicalpickles
approved these changes
Mar 5, 2019
Let me see if there's a decent npm module I can use to create tests for this. The problem is detecting the cyclic structure! |
mistydemeo
force-pushed
the
fix_circular_reference
branch
from
d7411f8 to
947d988
Compare
|
Updated to add tests using the |
|
🎉 This PR is included in version 3.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that Hubot is accidentally retaining some references to
robotandbrainin objects, leading to unserializable circular references. This fixes the issue bya) Ensuring temporary assignment of
robotto objects is removed, andb) Tucking
robotinside a getter function inBrain, instead of assigning it as a variable, like in theUserobject.