Skip to content

Commit

Permalink
feat: Make datastore async/await. (#1666)
Browse files Browse the repository at this point in the history
feat: Make datastore async/await.
feat: Make robot.run async/await.
feat: throw error instead of calling process.exit in try/catch. Let the process fail on its own.

fix: Shell adapter wasn't closing the Readline stream properly. It was causing test scenarios to hang.
fix: adapter.emote had a typo
fix: call removeAllListeners in close method.
fix: Response.play() wasn't working.
fix: argument being sent to the catchAll callback was not correct. It's supposed to be a CatchAllMessage type.

chore: Add @deprecated for Brain wrapper  methods in Adapter
chore: Remove is-circular
chore: Replace mocha with Node's Test Runner
chore: Remove chai, sinon and sinon-chai

BREAKING CHANGE: Updating datastore to async/await API.
BREAKING CHANGE: Bump Node support to v18
BREAKING CHANGE: Making robot.run async/await is an API change.

Get tests working with node v18.17.1.
It's fine if there's not a history file for the shell adapter.
fixed this[#rl].close is not a function in pipeline.
Possible race condition between loading the readline interface and call to close happening close together.
  • Loading branch information
joeyguerra authored Sep 23, 2023
1 parent a4c2ec8 commit bffe675
Show file tree
Hide file tree
Showing 23 changed files with 1,792 additions and 2,320 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/nodejs-ubuntu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:

strategy:
matrix:
node-version: [16.x, 18.x, latest]
node-version: [18.x, latest]

steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion bin/hubot.js
Original file line number Diff line number Diff line change
Expand Up @@ -153,5 +153,5 @@ function loadExternalScripts () {

robot.adapter.once('connected', loadScripts)

robot.run()
await robot.run()
})()
Loading

0 comments on commit bffe675

Please sign in to comment.