Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressed scrolling accessibility issue on homepage #3656

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Addressed scrolling accessibility issue on homepage #3656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41a4c3a
Addressed issue on homepage
tkakar Dec 19, 2024
df61208
Fixed changelog file
tkakar Dec 19, 2024
8fa4c0c
Merge branch 'main' into tkakar/cat-1083-fix-home-page
tkakar Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG-home-scrolling-accessibility-issue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Addressed accessibility issue on home page to ensure elements with scrollable content are accessible by keyboard.
0 CHANGELOG-scrolling-accessibility-issue → CHANGELOG-scrolling-accessibility-issue.md
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion context/app/static/js/shared-styles/charts/ChartWrapper/ChartWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function ChartWrapper({ children, chartTitle, margin, colorScale, dropdown, allK
</Box>
<Stack sx={{ paddingTop: `${margin.top}px`, height: `calc(100% - ${margin.bottom}px)`, maxWidth: 175 }}>
{dropdown && <Box sx={{ marginBottom: 1, minWidth: 0 }}>{dropdown}</Box>}
<Box sx={{ flex: 1, overflowY: 'auto' }}>
<Box sx={{ flex: 1, overflowY: 'auto' }} tabIndex={0}>
<LegendOrdinal
scale={colorScale}
labelMargin="0 15px 0 0"
Expand Down
Loading