-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
John conroy/search cleanup #3614
Merged
john-conroy
merged 6 commits into
john-conroy/replace-searchkit
from
john-conroy/search-cleanup
Nov 20, 2024
Merged
John conroy/search cleanup #3614
john-conroy
merged 6 commits into
john-conroy/replace-searchkit
from
john-conroy/search-cleanup
Nov 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickAkhmetov
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Should we remove searchkit in this branch as well?
We still need searchkit for dev-search 🙃. We could put it in a deprecated directory and file a ticket to replace dev-search at some point if time allows. |
john-conroy
added a commit
that referenced
this pull request
Nov 20, 2024
* Add changelog * Install elastic-builder * Type for es endpoint in context * Add basic search implementation * Display results * Fix util path * Add sorting * Get esfield from mapping * Refactor sort cell * Add term facet * Add hierarchical facet * Fix hierarchical facet * Add free text search * Add search scrolling * Fix alignment of results count * Add indeterminate state to term facet * Add highlighting * Add no results and fix spacing * Add builder to simplify config * Pull labels out of state * Simplify config * Switch out placeholder variable name * Add range facet * Update range facet when commited * Set filters at once * Filter aggs * Refactor aggs * Allow for facet groups in config * Add filter chips * Fix spacing * Temp update routes * Add tile view * Add tiles sort * Add selection and dropdown menus * Add header * Delete cells search * Add configs for each entity * Fix missing organs * Add support for default queries * Sync url state * Add redirect for old routes * Add tracking * Increase agg size * Track view more results * Handle last modied table cells * Refactor filter state * Fix hierarchical toggle * Don't show view more button if hits reached * Add expand for term facets * Update facets * Update labels, handle bools * Style * Refactor field configurations * Add agg sorting options * Use history * Update variable name * Add loading state * Fix width * Add json validation * Add function to build link * Add search note * Update links * Fix links * Refactor * Add index * Add comment * Uninstall qs * Move query build into fetch * Update store selectors * add memoization * suppress proptypes warning * suppress console warnings for invalid prop and tooltip on disabled button * decrease scope of facet state subscriptions spelling fixes * Memoize * Stash * Sort buckets using es * Slice buckets using state not es * Fix header cell styles * Fix table sizing * Fix search links * Fix donor age * Refactor styles * Fix metadata typo * John conroy/reset all filters (#3598) * Add reset method to store * Add reset filters button * Fix styles * Dedupe single valued hierarchical parents/children (#3599) Co-authored-by: John Conroy <[email protected]> --------- Co-authored-by: John Conroy <[email protected]> * John conroy/sort by pub CAT-970 (#3605) * Add support for secondary sort field * Sort published datasets first --------- Co-authored-by: John Conroy <[email protected]> * John conroy/date facets CAT-971 (#3606) * Add support for secondary sort field * Sort published datasets first * Install mui-x date pickers * Initial date picker facet * Handle reset * Fix fn * Add validation * Update configurations * Fix tests * Handle missing values * Review changes --------- Co-authored-by: John Conroy <[email protected]> * John conroy/toggle entities without datasets CAT-968 (#3608) * Add support for secondary sort field * Sort published datasets first * Install mui-x date pickers * Initial date picker facet * Handle reset * Fix fn * Add validation * Update configurations * Fix tests * Handle missing values * Initial facet * Handle inversion * Fix inversion * Convert field configs into hook make dependent on type * Fix logic * John conroy/select datasets on search CAT-984 (#3611) * Return isLoading from all search ids * Select all ids * Update tooltip --------- Co-authored-by: John Conroy <[email protected]> --------- Co-authored-by: John Conroy <[email protected]> * Fix cypress tests * Integrate bulk download * John conroy/search cleanup (#3614) * Update tracking * Fix range facet * Add hook to get mappings * Fix pep8 * Fix pep8 again * Fix track page --------- Co-authored-by: John Conroy <[email protected]> --------- Co-authored-by: John Conroy <[email protected]> Co-authored-by: Nikolay Akhmetov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
CHANGELOG-your-feature-name-here.md
is present in the root directory, describing the change(s) in full sentences.