Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

John conroy/search cleanup #3614

Merged
merged 6 commits into from
Nov 20, 2024

Conversation

john-conroy
Copy link
Collaborator

Summary

  • Add more tracking.
  • Fix range histogram facet bin coloring.
  • Add hook to retrieve mappings.

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

Copy link
Collaborator

@NickAkhmetov NickAkhmetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Should we remove searchkit in this branch as well?

@john-conroy
Copy link
Collaborator Author

We still need searchkit for dev-search 🙃. We could put it in a deprecated directory and file a ticket to replace dev-search at some point if time allows.

@john-conroy john-conroy merged commit 22d927f into john-conroy/replace-searchkit Nov 20, 2024
5 checks passed
@john-conroy john-conroy deleted the john-conroy/search-cleanup branch November 20, 2024 16:22
john-conroy added a commit that referenced this pull request Nov 20, 2024
* Add changelog

* Install elastic-builder

* Type for es endpoint in context

* Add basic search implementation

* Display results

* Fix util path

* Add sorting

* Get esfield from mapping

* Refactor sort cell

* Add term facet

* Add hierarchical facet

* Fix hierarchical facet

* Add free text search

* Add search scrolling

* Fix alignment of results count

* Add indeterminate state to term facet

* Add highlighting

* Add no results and fix spacing

* Add builder to simplify config

* Pull labels out of state

* Simplify config

* Switch out placeholder variable name

* Add range facet

* Update range facet when commited

* Set filters at once

* Filter aggs

* Refactor aggs

* Allow for facet groups in config

* Add filter chips

* Fix spacing

* Temp update routes

* Add tile view

* Add tiles sort

* Add selection and dropdown menus

* Add header

* Delete cells search

* Add configs for each entity

* Fix missing organs

* Add support for default queries

* Sync url state

* Add redirect for old routes

* Add tracking

* Increase agg size

* Track view more results

* Handle last modied table cells

* Refactor filter state

* Fix hierarchical toggle

* Don't show view more button if hits reached

* Add expand for term facets

* Update facets

* Update labels, handle bools

* Style

* Refactor field configurations

* Add agg sorting options

* Use history

* Update variable name

* Add loading state

* Fix width

* Add json validation

* Add function to build link

* Add search note

* Update links

* Fix links

* Refactor

* Add index

* Add comment

* Uninstall qs

* Move query build into fetch

* Update store selectors

* add memoization

* suppress proptypes warning

* suppress console warnings for invalid  prop and tooltip on disabled button

* decrease scope of facet state subscriptions
spelling fixes

* Memoize

* Stash

* Sort buckets using es

* Slice buckets using state not es

* Fix header cell styles

* Fix table sizing

* Fix search links

* Fix donor age

* Refactor styles

* Fix metadata typo

* John conroy/reset all filters (#3598)

* Add reset method to store

* Add reset filters button

* Fix styles

* Dedupe single valued hierarchical parents/children (#3599)

Co-authored-by: John Conroy <[email protected]>

---------

Co-authored-by: John Conroy <[email protected]>

* John conroy/sort by pub CAT-970 (#3605)

* Add support for secondary sort field

* Sort published datasets first

---------

Co-authored-by: John Conroy <[email protected]>

* John conroy/date facets CAT-971 (#3606)

* Add support for secondary sort field

* Sort published datasets first

* Install mui-x date pickers

* Initial date picker facet

* Handle reset

* Fix fn

* Add validation

* Update configurations

* Fix tests

* Handle missing values

* Review changes

---------

Co-authored-by: John Conroy <[email protected]>

* John conroy/toggle entities without datasets CAT-968 (#3608)

* Add support for secondary sort field

* Sort published datasets first

* Install mui-x date pickers

* Initial date picker facet

* Handle reset

* Fix fn

* Add validation

* Update configurations

* Fix tests

* Handle missing values

* Initial facet

* Handle inversion

* Fix inversion

* Convert field configs into hook make dependent on type

* Fix logic

* John conroy/select datasets on search CAT-984 (#3611)

* Return isLoading from all search ids

* Select all ids

* Update tooltip

---------

Co-authored-by: John Conroy <[email protected]>

---------

Co-authored-by: John Conroy <[email protected]>

* Fix cypress tests

* Integrate bulk download

* John conroy/search cleanup (#3614)

* Update tracking

* Fix range facet

* Add hook to get mappings

* Fix pep8

* Fix pep8 again

* Fix track page

---------

Co-authored-by: John Conroy <[email protected]>

---------

Co-authored-by: John Conroy <[email protected]>
Co-authored-by: Nikolay Akhmetov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants