Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NickAkhmetov/HMP-566 Make footer link icons consistent #3368

Merged
merged 1 commit into from
Jan 5, 2024
Merged

NickAkhmetov/HMP-566 Make footer link icons consistent #3368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG-HMP-566.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Add portal analytics link to maintenance page footer.
- Fix consistency of external link icon logic.
13 changes: 8 additions & 5 deletions context/app/static/js/components/Footer/Footer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ function Footer({ isMaintenancePage }) {
</FlexColumn>
<FlexColumn $mr={1}>
<Typography variant="subtitle2">Software</Typography>
<OutboundLink variant="body2" href="https://github.com/hubmapconsortium">
<OutboundIconLink variant="body2" href="https://github.com/hubmapconsortium">
GitHub
</OutboundLink>
</OutboundIconLink>
{!isMaintenancePage && (
<>
<InternalLink variant="body2" href="/services">
Expand All @@ -51,11 +51,14 @@ function Footer({ isMaintenancePage }) {
<InternalLink variant="body2" href="/apis">
APIs
</InternalLink>
<OutboundLink variant="body2" href="https://lookerstudio.google.com/u/0/reporting/bceef6eb-c727-4b6f-ac00-364b280ae8c2/page/p_o7z46wg18c">
Portal Usage Analytics
</OutboundLink>
</>
)}
<OutboundIconLink
variant="body2"
href="https://lookerstudio.google.com/u/0/reporting/bceef6eb-c727-4b6f-ac00-364b280ae8c2/page/p_o7z46wg18c"
>
Portal Usage Analytics
</OutboundIconLink>
</FlexColumn>
<FlexColumn $mr={1}>
<Typography variant="subtitle2">Policies</Typography>
Expand Down
Loading