NickAkhmetov/HMP-389 Hotfix lint issues #3258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note I made these same fixes in 3215; if we are ready to merge that work in, this branch can be closed. |
john-conroy
approved these changes
Sep 13, 2023
| @@ -38,7 +38,7 @@ function AutocompleteEntity({ targetEntity, setter }: AutocompleteEntityProps) { | |||
| const { data, isLoading } = useAutocompleteQuery({ targetEntity, substring }); | |||
|
|
|||
| // Include currently selected options to avoid invalid value errors in console | |||
| const options = selectedOptions.concat(data || []); | |||
| const options = selectedOptions.concat(data ?? []); | |||
There was a problem hiding this comment.
Is this out of precaution against potentially falsy data or did you notice data that necessitated this?
There was a problem hiding this comment.
data is initially undefined when the page first loads. I added a console.log(data) call to demonstrate:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the lint issues that slipped through when I merged in HMP-389; since that branch was opened before updates to lint packages were added, CI did not pick up these issues earlier.