Nickakhmetov/HMP-349 / HMP-361 Update shared icons/links to use TS/MUI Styles #3255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x alpha conversions
* bump dependency versions * Only use typescript rules with typescript files * use nullish coalescer instead of ternary * Prefer interfaces over types * type the `groups` arg itself as LinkGroupType * Fix `rest` props * avoid unsafe assignment of `any` value by typing styled components * update to prettier 3, update eslint prettier plugin accordingly * rerun `lint:fix` after prettier 3 upgrade * clean up unsafe assignment of `any` value * type LinkButton as an anchor element * fix remaining "unsafe color cast" * add prettier as default yaml formatter * add ignore paths for prettier, add prettier linting for md/json/yaml * Fix parser settings in prettierrc, target all files in ingest-validation-tools * apply upstream package.json changes * changelog + fixed settings.json to properly identify "markdown" vs. "md" * use `.ts` extension when exporting types * NickAkhmetov/HMP-390 Apply `prettier` formatting to `md`, `json` and `yaml` files (#3250) * Run `prettier write .` * use `.ts` extension when exporting types * Keep `eslint` calls confined to only eslint file types * Revert html template changes, add to prettierignore * Add plugins to let ESLint parse MD/JSON/YAML and hand them off to prettier for formatting * `prettier --write .` * Prettier fixes * fix imports in tutorial cypress test
Base automatically changed from
nickakhmetov/hmp-371-mui-palette-cleanup
to
main
September 12, 2023 16:08
john-conroy
previously approved these changes
Sep 13, 2023
I'll look into how I can improve on this. There are a lot of icons throughout the site which were dependent on the |
john-conroy
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the
iconsandlinksdirectories' components to be fully TypeScript compatible and enables the use ofsxand other MUI props on the styled icons.Styled icons still default to 1rem by default, and appearance matches prod.