Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is ".h5ad" precise enough? #13

Open
mccalluc opened this issue Feb 25, 2020 · 2 comments
Open

Is ".h5ad" precise enough? #13

mccalluc opened this issue Feb 25, 2020 · 2 comments

Comments

@mccalluc
Copy link
Contributor

@mruffalo : Looking back at this again, is it sufficiently precise to just look for the .h5ad extension, or is the same file format likely to be used for other kinds of data? If it's not sufficiently precise, could you suggest a longer extension (.something.h5ad) that you could produce, and we would look for, and then assign back to me?

@mruffalo
Copy link
Contributor

As far as I know, .h5ad is only used for "HDF5 following the AnnData convention", so that should be precise enough.

@mccalluc
Copy link
Contributor Author

@mruffalo : Sorry I didn't phrase that more clearly. I'm not worried about an ".h5ad" not being the right kind of HDF5, but it's a general format, and could conceivably be used to store something other than umap. For now, our pipeline starts when files with a recognized extension is seen, so I think we'd want to distinguish between ".umap.h5ad" and ".something-else.h5ad".

(I'm not sure exactly where this logic is right now: I believe that Joel has done work in ingest-api that references my cwl in airflow-dev.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants