Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to fix row numbering discrepancy #1331

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

gesinaphillips
Copy link
Collaborator

@gesinaphillips gesinaphillips commented May 13, 2024

Row numbers didn't match between Spreadsheet Validator response and IVT validation. This change mutates the Spreadsheet Validator responses because they are less human-readable to start with. Errors returned by failed URL checks have also always had an off-by-one row number so that is fixed here.

@gesinaphillips gesinaphillips marked this pull request as ready for review May 15, 2024 15:01
@gesinaphillips gesinaphillips requested a review from maxsibilla May 15, 2024 15:01
@gesinaphillips gesinaphillips merged commit b42126e into main May 15, 2024
8 checks passed
@gesinaphillips gesinaphillips deleted the phillips/line_numbering branch May 15, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants