Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORCID bugfix #1322

Merged
merged 2 commits into from
Apr 15, 2024
Merged

ORCID bugfix #1322

merged 2 commits into from
Apr 15, 2024

Conversation

gesinaphillips
Copy link
Collaborator

ORCID URL checking appears not to have been working properly for a few reasons:

  • change from field name orcid_id to orcid
  • Use of an inappropriate URL
  • Testing filtering out "Unauthorized" errors (because this is what happens when you forget a Globus token and we don't want to write this data to the fixtures mistakenly) may have obscured this.

This fix makes use of a general testing ORCID.

@gesinaphillips gesinaphillips requested review from sunset666 and jpuerto-psc and removed request for jpuerto-psc April 15, 2024 15:32
@gesinaphillips gesinaphillips marked this pull request as draft April 15, 2024 15:34
@gesinaphillips gesinaphillips marked this pull request as ready for review April 15, 2024 16:22
@gesinaphillips gesinaphillips merged commit bf9e76d into main Apr 15, 2024
8 checks passed
@gesinaphillips gesinaphillips deleted the phillips/orcid_bugfix branch April 15, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpuerto-psc jpuerto-psc jpuerto-psc approved these changes

@sunset666 sunset666 sunset666 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gesinaphillips @sunset666 @jpuerto-psc