-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation update #1321
Documentation update #1321
Conversation
…xed" - making new branch This reverts commit 1c55578.
@gesinaphillips I think I prefer the method of having a single |
Having slept on this a bit, I agree @jpuerto-psc. On it! |
This PR does two main things:
I was really not sure how we want to do this since I know we want to keep the files rather than deleting. I chose to go with in-place_deprecated
directories, but an alternative is to have a top-level_deprecated
directory with sub-dirs that mirror the original locations of the deprecated files. E.g.docs/field-assays.yaml
->_deprecated/docs/field-assays.yaml
. This would consolidate things better but may be somewhat confusing as a directory.Or we could just dump them all in one folder.Anyway let me know what you think._deprecated
directory.offline
parameter on Upload withno_url_checks
as there is no longer a true offline validation path. However, previous gen validation tries to run online URL checks unless they are explicitly turned off, so this is necessary for testing. This change also allows for user-facing documentation forvalidate_upload.py
to hand-wave the portion about obtaining a Globus token, as that functionality can be turned off (this does of course mean that a user could validate locally and still have URL check errors when they submit their upload, but that seems like a small trade-off considering the currently busted status). This update allows for a (potentially temporary) state of correct user-facing documentation for how to usevalidate_upload.py
to validate an upload's directory schema.