Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL checks error reformatting #1315

Merged
merged 5 commits into from
Mar 25, 2024
Merged

URL checks error reformatting #1315

merged 5 commits into from
Mar 25, 2024

Conversation

gesinaphillips
Copy link
Collaborator

@gesinaphillips gesinaphillips commented Mar 21, 2024 •
edited
Loading

  • Changed _url_checks to call _get_message to mirror how _api_validation returns (request for better SenNet compatibility).
  • Removed redundant nested path keys in online_checks reporting.
  • Updated README.md files accordingly.
  • Updated fixtures from current output of assayclassifier endpoint.

@gesinaphillips gesinaphillips marked this pull request as ready for review March 21, 2024 20:01
maxsibilla
maxsibilla approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@maxsibilla maxsibilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the SenNet Data Sharing Portal

@gesinaphillips gesinaphillips merged commit dc04852 into main Mar 25, 2024
8 checks passed
@gesinaphillips gesinaphillips deleted the phillips/url_check_reformat branch March 25, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpuerto-psc jpuerto-psc jpuerto-psc approved these changes

@sunset666 sunset666 sunset666 approved these changes

@maxsibilla maxsibilla maxsibilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gesinaphillips @maxsibilla @sunset666 @jpuerto-psc