Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popv updates #20

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Popv updates #20

merged 2 commits into from
Oct 2, 2024

Conversation

axdanbol
Copy link
Collaborator

@axdanbol axdanbol commented Oct 2, 2024

No description provided.

Popv has fixed the bug that made onclass fail in fast mode annotations
Base image already provides python & pip
@axdanbol axdanbol self-assigned this Oct 2, 2024
@axdanbol axdanbol requested a review from bherr2 October 2, 2024 18:12
@@ -1,6 +1,6 @@
FROM tensorflow/tensorflow:2.16.1

RUN apt-get -y update && apt-get -y install python3-dev python3-pip g++ git wget && apt-get clean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the tensorflow docker already installs those dependencies you removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it has python, pip, and wget

Copy link
Member

@bherr2 bherr2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to merge when ready.

@axdanbol axdanbol merged commit 118a0e8 into main Oct 2, 2024
@axdanbol axdanbol deleted the popv-updates branch October 2, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants