Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUI Y3 cosmetic updates #736

Open
LibbyUX opened this issue Sep 25, 2024 · 7 comments
Open

RUI Y3 cosmetic updates #736

LibbyUX opened this issue Sep 25, 2024 · 7 comments
Assignees
Labels
app: ccf-rui Registration User Interface update: cosmetics 💄 Cosmetic UI updates Y3: ds-alignment Align all current UIs cosmetically with the design system

Comments

@LibbyUX
Copy link
Contributor

LibbyUX commented Sep 25, 2024

Design Start: RUI Y3 Cosmetic Update

Design work begins today. Attempting a review submission by Friday EOB.

Current Implementation

  • 1280x832 is our minimum breakpoint and features are super cramped in the current implementation app. I will iterate & improve:

Entry Point 1920x1080

image

App 1280x832

image

App 1920x1080

image

@LibbyUX LibbyUX added app: ccf-rui Registration User Interface update: cosmetics 💄 Cosmetic UI updates Y3: ds-alignment Align all current UIs cosmetically with the design system labels Sep 25, 2024
@LibbyUX LibbyUX added this to the Design: DS Alignment milestone Sep 25, 2024
@LibbyUX LibbyUX self-assigned this Sep 25, 2024
@LibbyUX
Copy link
Contributor Author

LibbyUX commented Nov 1, 2024

Ready for dev: RUI cosmetic redesign

Please contact me if you have any questions!

Updates

Design system components have been added everywhere for this cosmetic redesign!

Entry point

  • The entry point is now a full screen modal.
  • Search autocomplete is needed for organs and consortia.

Application

  • More menus added
  • Flyouts added for AS and landmarks opacity and tissue block rotation sliders
  • The position reporting has been moved from inside the 3D scene to the position column in the Tissue Block Settings panel

Review and download modal

  • This modal reports the user's registration in a tabular format. We use our scrollbar that appears on hover if needed.
  • A snackbar appears after the user has downloaded their registration.

Resources

Open issues that are related to this design/build:

image

@LibbyUX
Copy link
Contributor Author

LibbyUX commented Nov 13, 2024

@edlu77 & @axdanbol - I started to review the RUI preview today. I noticed that I missed specifying a "we log usage" snackbar, so I added one here in Figma.

The preview is looking amazing! I'll review more of the RUI shortly!

image

@LibbyUX
Copy link
Contributor Author

LibbyUX commented Nov 22, 2024

Meeting notes from RUI build check in:

@edlu77 - Thanks for meeting with me today! This build is looking so good! We discussed:

AS & Landmark flyout behavior

image

Interaction:

  • Click the opacity button to open the flyout.
  • The flyout opens centered to the right of the AS or Landmark.
  • The AS or Landmark shows a selected state while the flyout is open (if possible).
  • The flyout is closed when clicking anywhere outside of the flyout.

Rotation input/slider flyout behavior

image

More info needed: Rotation slider keyboard modifier

image

Looping in @andreasbueckle and @bherr2 about our Figma comment thread on this feature. I recall I started this thread because Andi asked if this would be possible, so, we discussed adding a shift button keyboard modifier for the rotation sliders to make it easier for users to be precise in the rotation for their tissue blocks.

Currently, the slider moves in increments of 1 degree, but the ask was to use the keyboard modifier for 1 degree. Edward and I both need to understand precisely how this request is supposed to function. @andreasbueckle and/or @bherr2, can you please follow up with more details about the expected behavior of this interaction?

@andreasbueckle
Copy link
Contributor

@LibbyUX
We could try increases of 0.5 degrees when the user presses the shift key while using the slider. Maybe we can have a test build with different speeds? Happy to sit with @edlu77 and test different increments.

@andreasbueckle
Copy link
Contributor

andreasbueckle commented Nov 22, 2024

PS: @LibbyUX
Tinkercad has a good implementation of modified rotation:
image

It allows two speeds: 1 degree and 22.5 degrees. In the RUI, we would have 1 degree and 0.5 degrees. Happy to demo to @LibbyUX or @edlu77

image

image

@LibbyUX
Copy link
Contributor Author

LibbyUX commented Dec 9, 2024

Hi @bherr2 & @andreasbueckle - I have a question about a specific interaction in the RUI under two different conditions. This is for the "reset tissue block" button in the registration panel with the 3D viewer. @edlu77 noted that the current RUI 3D viewer panel resets differently based on if there is a previous registration file or not:

  • Using the reset button on registrations without a previous registration file: Clicking this button resets the RUI location to the default position, size, and rotation.
  • When a previous registration file is used: Clicking this button resets the RUI to the uploaded registration file's original position, size, and rotation.

I want to confirm that this is the intended interaction. This seems like it was intentional, but Edward and I want to verify. Thank you!

Screenshot 2024-12-09 at 6 33 34 PM

@LibbyUX
Copy link
Contributor Author

LibbyUX commented Dec 12, 2024

@axdanbol - Thank you for chatting RUI with me this week!

I edited the spec to show our agreed-on required text field formatting, please see the metadata input field component here! I appreciate you and I hope your day is starting well!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: ccf-rui Registration User Interface update: cosmetics 💄 Cosmetic UI updates Y3: ds-alignment Align all current UIs cosmetically with the design system
Projects
None yet
Development

No branches or pull requests

4 participants