Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NickAkhmetov/HMP-519 Update maintenance bundle to look up maintenance message from S3 #303

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

NickAkhmetov
Copy link
Contributor

This PR updates the maintenance page bundle to include the functionalities added in hubmapconsortium/portal-ui#3364 - i.e. the maintenance page now fetches a .md file from the s3 bucket which contains the text to be displayed.

@lchoy lchoy requested a review from yuanzhou January 4, 2024 15:36
@yuanzhou
Copy link
Member

yuanzhou commented Jan 5, 2024

@lchoy and @NickAkhmetov, this is a brilliant idea! Only a very minor issue I noticed today, maybe it has been like this since the beginning. The links at the footer are all external links, but only two has that external link icon. Would you mind updating them for the sake of consistency?
Screenshot 2024-01-05 at 9 20 08 AM

@NickAkhmetov
Copy link
Contributor Author

@yuanzhou That's an interesting question! This is the same footer we have in the rest of the data portal application, minus the links to internal pages, so this does largely match the rest of the site.

With some of these links (project website, data sharing policy, overview) I can see why we don't have an external link icon, as these are technically still HuBMAP sites. However, GitHub should probably have an external link icon by this logic.

@tsliaw, do you recall what criteria we use to determine whether to use an external link icon or not?

@NickAkhmetov
Copy link
Contributor Author

After confirming with Tiffany,

  • We will add it to the GitHub link
  • We are adding it to the portal analytics link and making sure the portal analytics link appears in maintenance mode

@NickAkhmetov
Copy link
Contributor Author

@yuanzhou It should be all set now - I rebuilt the maintenance page from the branch where I have the footer links updated: hubmapconsortium/portal-ui#3368

Updated maintenance footer:
294593317-a0f822bb-5f27-43e4-9f96-e6fa7bc044f2

@yuanzhou
Copy link
Member

yuanzhou commented Jan 5, 2024

@NickAkhmetov thank for your attention to details!

@yuanzhou yuanzhou merged commit c924df8 into main Jan 5, 2024
2 checks passed
@yuanzhou yuanzhou deleted the nickakhmetov/editable-maintenance branch January 26, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants