Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 17 update #1221

Merged
merged 15 commits into from
Jan 24, 2024
Merged

Angular 17 update #1221

merged 15 commits into from
Jan 24, 2024

Conversation

edlu77
Copy link
Collaborator

@edlu77 edlu77 commented Jan 22, 2024

No description provided.

@edlu77 edlu77 requested review from axdanbol and bherr2 January 22, 2024 15:30
@edlu77 edlu77 self-assigned this Jan 22, 2024
Copy link

github-actions bot commented Jan 22, 2024

🚀 Preview Deploy Report Updated

✅ Successfully deployed preview here

Copy link
Collaborator

@axdanbol axdanbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove .nx/cache files and add .nx to the .gitignore

projects/ccf-eui/src/themes/_dark.scss Outdated Show resolved Hide resolved
projects/ccf-eui/src/themes/_default_light.scss Outdated Show resolved Hide resolved
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

33.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@axdanbol axdanbol merged commit 7fe920f into develop Jan 24, 2024
2 of 3 checks passed
@axdanbol axdanbol deleted the angular-17-update branch January 24, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants