Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up baseUrl + add test wc #1214

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Set up baseUrl + add test wc #1214

merged 5 commits into from
Jan 9, 2024

Conversation

edlu77
Copy link
Collaborator

@edlu77 edlu77 commented Jan 8, 2024

@edlu77 edlu77 requested a review from bherr2 January 8, 2024 16:02
@edlu77 edlu77 self-assigned this Jan 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024 •
edited
Loading

🚀 Preview Deploy Report Updated

✅ Successfully deployed preview here

@bherr2
Copy link
Member

bherr2 commented Jan 8, 2024

Getting errors on build preview:

ERROR Error: Error retrieving icon app:visibility_on! Http failure response for https://659c1e5ce26540007bbdd7a9--hubmap-ccf-ui.netlify.app/undefinedassets/icons/visibility-on-24px.svg: 404 OK

Looks like baseHref is not propagating

@edlu77 edlu77 merged commit 0911d40 into develop Jan 9, 2024
2 checks passed
@edlu77 edlu77 deleted the eui-basehref branch January 9, 2024 18:12
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

45.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bherr2 bherr2 Awaiting requested review from bherr2

Assignees

@edlu77 edlu77

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edlu77 @bherr2