Add arch test for preview API usage #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bitwiseman Based on the discussion we had in this PR #960 I decided to implement some architecture tests to cover the Thoughts? |
sullis
suggested changes
Nov 25, 2020
bitwiseman
approved these changes
Nov 30, 2020
marcoferrer
force-pushed
the
add-preview-arch-rules
branch
from
5504d1f to
459d1b4
Compare
|
@bitwiseman addressed feedback, simplified implementation, added another rule to check for preview APIs in enum fields |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the concept of architecture tests to the project. The first test implemented verifies that any method or class that is annotated
@Previewis also annotated with@Deprecated.The library used to implement the tests is ArchUnit
The following is an example of the output created when this test fails.
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master. Create your PR from that branch.mvn clean compilelocally. This may reformat your code, commit those changes.mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.When creating a PR: