Add ability to update a check run #980
Conversation
they are recorded files mostly, possibly with small tweaks on top, I've invited you to the test org |
|
Hmm, the tests for checks appear to use a repo owned by @jglick (along with a corresponding app). |
might be better to migrate them to the test org |
|
Ok, I'll see what I can do 👍 |
|
Well that was churny :) All passing now @timja, thanks for sorting me out with the access. |
| GHCheckRun checkRun = gitHub.getRepository("jglick/github-api-test") | ||
| .createCheckRun("foo", "4a929d464a2fae7ee899ce603250f7dab304bc4b") | ||
| GHCheckRun checkRun = getInstallationGithub().getRepository("hub4j-test-org/test-checks") | ||
| .createCheckRun("foo", "89a9ae301e35e667756034fdc933b1fc94f63fc1") |
There was a problem hiding this comment.
Is there a reason you needed to update existing tests? Once the mocks are created they should continue to work so long as you are not actually changing the behavior of the existing APIs, which AFAICT you are not.
There was a problem hiding this comment.
It was to make it easier to update them for others by moving the tests to the test org and an app that others can use I believe (could be a separate pr)
|
Hmm, from looking at how this might be used downstream, it could probably do with a |
given that create is there https://github.com/hub4j/github-api/blob/master/src/main/java/org/kohsuke/github/GHRepository.java#L1957 I don't see why not |
|
@bitwiseman did you want to take a look at this? |
Add functionality to update an existing check run
I have added a test which I fully expect to fail, as I have no idea where to even begin with implementing the wiremock backend - are they all manually crafted files?