GHCheckRun.getPullRequests public #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwiseman
reviewed
Jul 30, 2020
bitwiseman
requested changes
Jul 30, 2020
bitwiseman
reviewed
Jul 30, 2020
added 3 commits
July 30, 2020 21:41
bitwiseman
approved these changes
Jul 30, 2020
|
@bitwiseman is this fine to merge now? |
|
@JKalash I fixed those issues and added more tests. |
bitwiseman
reviewed
Jul 31, 2020
Comment on lines
+131
to
+132
| * Note this field is only populated for events. When getting a {@link GHCheckRun} outside of an event, this is | ||
| * always empty. |
There was a problem hiding this comment.
@JKalash
Keep this in mind. This is took me a while to figure out. I'm not sure if it is expected behavior from GitHub but it is consistent.
Turns out there were quite a few bugs in this area (it was exposed publicly before. Some tweaking was needed and updates to the tests to show this working as expected.
bitwiseman
force-pushed
the
jkalash/master
branch
from
c26aee2 to
b177d98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #908 (GHCheckRun's getPullRequests should be public)
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
When creating a PR: