Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MAINTAIN and TRIAGE to GHOrganization.Permission enum #904

Merged
merged 2 commits into from
Jul 28, 2020

Conversation

Javaru
Copy link
Contributor

@Javaru Javaru commented Jul 27, 2020

Description

The GHOrganization.Permission enum is missing the MAINTAIN and TRIAGE permissions. Currently the enum only has ADMIN, PUSH, and PULL. The five possible permissions are listed in the GitHub documentation for the permissions parameter for organization teams and collaborators.

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than master. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn clean compile locally. This may reformat your code, commit those changes.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

When creating a PR:

  • Fill in the "Description" above.
  • Enable "Allow edits from maintainers".

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would generally expect tests but I'm okay in this case with taking the new values based on manual review. Thanks!

@bitwiseman bitwiseman merged commit 67dc6d2 into hub4j:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants