Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHBranch getProtection method to return correct number of reviewers #890 #895

Merged
merged 5 commits into from
Jul 17, 2020
Merged

GHBranch getProtection method to return correct number of reviewers #890 #895

merged 5 commits into from
Jul 17, 2020

Conversation

jeetchoudhary
Copy link
Contributor

@jeetchoudhary jeetchoudhary commented Jul 17, 2020

Description

Fix GHBranch getProtection method to return correct number of reviewers configured in branch protection. Headers require change for the request.
added https://github.com/jeetchoudhary/github-api/blob/master/src/main/java/org/kohsuke/github/Previews.java#L45 to the headers

Fixes #890

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than master. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn clean compile locally. This may reformat your code, commit those changes.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

When creating a PR:

  • Fill in the "Description" above.
  • Enable "Allow edits from maintainers".

@jeetchoudhary
Copy link
Contributor Author

@bitwiseman please review

bitwiseman and others added 2 commits July 17, 2020 10:50
@bitwiseman bitwiseman merged commit 727932a into hub4j:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GHBranchProtection::RequiredReviews.getRequiredReviewers() always return 0
2 participants