Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHTeamBuilder#parentTeamId now accepts a long instead of an int #851

Merged
merged 3 commits into from
Jun 22, 2020
Merged

GHTeamBuilder#parentTeamId now accepts a long instead of an int #851

merged 3 commits into from
Jun 22, 2020

Conversation

MarcosCela
Copy link

Closes #850

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test please.

…d relation

Additionally, ensure that when creating the team and setting the parentTeamId
on the GHTeamBuilder, we receive it directly from a previously retrieved
GHTeam. This ensures that the return type of GHTeam#getId() is compatible
with GHTeamBuilder#parentTeamId()
@MarcosCela
Copy link
Author

First time using WireMock but I think that this should do the trick!

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

@bitwiseman bitwiseman merged commit 8e2c1d7 into hub4j:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GHTeamBuilder#parentTeamId should accept a long
2 participants