-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for fetching what teams are part of this team. #849
Added support for fetching what teams are part of this team. #849
Conversation
I tried following the setup guide for writing tests, but without success, I got:
And didn't really understand why that happened. |
@alexanderkjall |
Also, please describe the steps you followed from the guide and the result from each step. |
The problem that I had was due to not being a part of the test organization, once I was added it worked without problem. |
171c7a9
to
51319c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexanderkjall
I removed getChildTeams()
- it is extremely easy to call listChildTeams().toSet()
. If you feel strongly otherwise, we can add it to the next release.
Description
The call is to this endpoint https://developer.github.com/v3/teams/#list-child-teams-legacy
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master
. Create your PR from that branch.mvn clean compile
locally. This may reformat your code, commit those changes.mvn -D enable-ci clean install site
locally. If this command doesn't succeed, your change will not pass CI.When creating a PR: