Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bio, hireable, and twitter_username fields to Person #838

Merged
merged 3 commits into from
Jun 8, 2020

Conversation

Chew
Copy link
Contributor

@Chew Chew commented Jun 6, 2020

Description

** Describe your change here**
This adds 3 fields to the GHPerson abstract method
getBio() which returns the user's bio as a String
getTwitterUsername() which returns their Twitter username as a String
isHireable() which returns if they're hirable as a boolean. (The API itself says "hireable", I am just going off of what that says)

These all appear for People and Organizations as well.

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than master. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn clean compile locally. This may reformat your code, commit those changes.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://developer.github.com/v3/orgs/#update-an-organization

Looks like organization doesn't have hireable or bio. So those should be moved to GHUser.

Then please add test(s) that include reading each of these fields from somewhere in a non-null/or non-false form.

@Chew
Copy link
Contributor Author

Chew commented Jun 7, 2020

Oh I see, if I do /users/:org it shows up, but if I do /orgs/:org it doesn't show up. Why is the API so confusing? I'll move it over!

@Chew Chew force-pushed the feature/new-profile-data branch from 4695b54 to dee4e6c Compare June 7, 2020 05:55
@bitwiseman
Copy link
Member

@Chew
And finally a user or org with non-null twitter_username.

@Chew
Copy link
Contributor Author

Chew commented Jun 7, 2020

I changed it to my profile since it

  1. had a not null bio
  2. had a not null twitter username
  3. hireable is true

@bitwiseman bitwiseman merged commit 4c5e018 into hub4j:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants