Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed getRef() to use git/ref endpoint instead of git/refs #822

Merged
merged 1 commit into from
May 21, 2020

Conversation

bitwiseman
Copy link
Member

Fixes #794

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than master. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn clean compile locally. This may reformat your code, commit those changes.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

@bitwiseman bitwiseman merged commit 3082622 into hub4j:master May 21, 2020
@bitwiseman bitwiseman deleted the issue/794 branch May 21, 2020 18:02
@mrginglymus
Copy link
Contributor

Hi. Seemingly because of this change, this API can no longer be used with GHE 2.18, which 404s when you attempt to access e.g. api/v3/repos/:org/:repo/git/ref/heads/master instead of api/v3/repos/:org/:repo/git/refs/heads/master.

@bitwiseman
Copy link
Member Author

@mrginglymus For future reference, commenting on closed PRs without opening an issue generally will not get you problem the attention it deserves. Please open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getRef method bug
2 participants