Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to unset the milestone of an issue #773

Merged
merged 2 commits into from
Apr 5, 2020

Conversation

martinvanzijl
Copy link
Contributor

@martinvanzijl martinvanzijl commented Apr 5, 2020

Description

One can now unset the milestone of an issue using issue.setMilestone(null).

Fixes #444.

Having the editNullable method alongside the edit method is a little ugly. Let me know if there is a better way to do this.

@martinvanzijl
Copy link
Contributor Author

I got an email saying the CI run failed (but seems successful above). Should I merge changes from latest master?

@bitwiseman
Copy link
Member

@martinvanzijl
Re: Having the editNullable.
It's not beautiful but I'm okay with it.

@bitwiseman bitwiseman merged commit 081e485 into hub4j:master Apr 5, 2020
@martinvanzijl martinvanzijl deleted the issue_444_unset_milestone branch April 6, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Milestones can not be unset
2 participants