Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrapUp() for GHEventPayload.CheckSuite #758

Merged
merged 2 commits into from
Mar 30, 2020

Conversation

XiongKezhi
Copy link
Contributor

@XiongKezhi XiongKezhi commented Mar 27, 2020

Description

Added a warp up method for check suite.

It seems the JavaDoc and tests are not needed because I see other payload objects also don't provide them for their warpUp() method. I will add them if required.

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than master. Create your PR from that branch.
  • Add JavaDocs and other comments.
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn -D enable-ci clean install site locally. This may reformat your code, commit those changes. If this command doesn't succeed, your change will not pass CI.

@bitwiseman bitwiseman changed the title Add warpUp() for GHEventPayload.CheckSuite Add wrapUp() for GHEventPayload.CheckSuite Mar 30, 2020
Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to get events better tested, but that doesn't need to happen in this PR.

@bitwiseman bitwiseman merged commit 8d47c72 into hub4j:master Mar 30, 2020
@XiongKezhi XiongKezhi deleted the add-check-suite-warp-up branch March 30, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants