Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten generated test resource paths #756

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

bitwiseman
Copy link
Member

@bitwiseman bitwiseman commented Mar 26, 2020

Description

I ran into the windows path limit again and decided to make it less likely to be exceeded in future.

This change makes the file names for test resources even shorter and more readable but changing the from UUIDs to indexes.

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than master. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn -D enable-ci clean install site locally. This may reformat your code, commit those changes. If this command doesn't succeed, your change will not pass CI.

@bitwiseman bitwiseman merged commit 2aef356 into hub4j:master Mar 26, 2020
@bitwiseman bitwiseman deleted the task/shorter branch March 26, 2020 22:52
@jglick
Copy link
Contributor

jglick commented Mar 26, 2020

I am afraid this is going to clash with #753, not sure how to fix.

@bitwiseman
Copy link
Member Author

bitwiseman commented Mar 27, 2020

@jglick
You can delete the test resource files and regenerate them or leave them as is. The test resources you generated should still work, they just have a different naming convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants